Dev

[epbay01]

No description provided.

[JohnnyWeymouth]

@koubarlow @epbay01 This could potentially break prd version of PyFS, as it is not yet relying on the PyPi version of pybugreporter. The dev branch is, but we need to push that forward first. We won't ever have to worry about stuff like this when we are using PyPi version numbers, which will be nice

[JohnnyWeymouth]

As well as anything else that depends on PyBugReporter, which is actually a lot. We just need to update their requirements.txt files

[epbay01]

i added default params to everything so i don't think it would tbh, since the discord bot is optional. you can look over the code and double check if you're worried about it tho

[epbay01]

i did do some refactoring of the async stuff so i guess that could break it, but i don't really know how to test it other than with the test file i had (locally), like in a production environment for example

[JohnnyWeymouth]

Hmm yeah it likely won't cause an issue, but if you want to test it, you could clone a repo that depends on it, change the version of PyBugReporter to be your new branch in requirement.txt, install all the requirments, then add a 'raise Exception' statement at the start of the repo's code, and see if PyBugReporter works properly at reporting it to that repo and discord