fixed manual bug report, also added discord stuff#67
Merged
Conversation
jilliangbaker97
approved these changes
May 27, 2025
bakerb
approved these changes
May 27, 2025
bakerb
left a comment
bakerb
left a comment
There was a problem hiding this comment.
Looks good. One question about some commented out code.
| has() | ||
| exception() | ||
| this() | ||
| # def this(): |
There was a problem hiding this comment.
What's the reasoning for keeping commented out code in the test? Do you sometimes uncomment and run it?
Contributor
Author
There was a problem hiding this comment.
yeah i was doing that to test various conditions for the error, like when certain parts are really long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realized the manual bug report is broken because i renamed some functions. also added discord functionality while i'm at it