fix(pdo): avoid PdoMaps(0,0) aliasing; delegate combined PDO to rx/tx#634
Closed
surajSFDC wants to merge 1 commit intocanopen-python:masterfrom
Closed
fix(pdo): avoid PdoMaps(0,0) aliasing; delegate combined PDO to rx/tx#634surajSFDC wants to merge 1 commit intocanopen-python:masterfrom
surajSFDC wants to merge 1 commit intocanopen-python:masterfrom
Conversation
- Add PdoMaps map_offset/com_offset and __getitem__ fallbacks for record indices - Replace dict merge with _CombinedPdoMaps; route 0x1400-0x17FF/0x1800-0x1BFF in PDO - Expand PdoBase fast path to 0x1400-0x1BFF; fix CiA 301 mapping tests (0x1A00 TPDO) - Add test_pdo_iterate Fixes flawed combined-PDO approach from PR canopen-python#613 (dummy zero offsets). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.