Skip to content

Add ReplyEntry::entry_with_ttls for distinct TTLs#667

Merged
cberner merged 1 commit intocberner:masterfrom
AM5800:push-oktmumtymmrz
Apr 13, 2026
Merged

Add ReplyEntry::entry_with_ttls for distinct TTLs#667
cberner merged 1 commit intocberner:masterfrom
AM5800:push-oktmumtymmrz

Conversation

@AM5800
Copy link
Copy Markdown
Contributor

@AM5800 AM5800 commented Apr 9, 2026

Currently, ReplyEntry::entry forces the same TTL for both the directory entry and its attributes.

In our VFS in certain situations we need to audit all access, including stat, so we set attribute cache duration to zero.

Setting entry cache to zero at the same time completely destroys performance, so I would like to add an ability to configure these timeouts separately.

Copy link
Copy Markdown
Owner

@cberner cberner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise lgtm

Comment thread src/reply.rs
Currently, `ReplyEntry::entry` forces the same TTL for both the
directory entry and its attributes. 

In our VFS in certain situations we need to audit all access, 
including stat, so we set attribute cache duration to zero. 

Setting entry cache to zero at the same time completely destroys 
performance, so I would like to add an ability to configure these 
timeouts separately.
@AM5800 AM5800 force-pushed the push-oktmumtymmrz branch from 087494a to daa433c Compare April 13, 2026 12:22
@AM5800 AM5800 requested a review from cberner April 13, 2026 12:22
@cberner cberner merged commit d3b89aa into cberner:master Apr 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants