Open
Conversation
|
I am unable to submit review because of the size of the PR , the page becomes unresponsive. All looks good to me. |
RamilCDISC
approved these changes
Mar 13, 2026
Contributor
|
Due to the size, I will be writing review comments here instead of on the files |
Contributor
|
What is the purpose of the empty "engine" folder? |
Contributor
|
There is an issue with this header (3.0 | 3.1 | 3.1.1): |
Collaborator
Author
it is a github submodule of engine--verizian did the same thing and we will use it for the scripts/gitactions for authors. Not entirely sure why it is empty for you |
Collaborator
Author
this came from the FULL template rule, I deleted it and remade the mappings which resolved it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left the audit file inside the repo for now--can remove but I want the rules with multiple test data sources to be resolved beforehand.