Skip to content

Initial Rules and Data#2

Open
SFJohnson24 wants to merge 7 commits intomainfrom
rules
Open

Initial Rules and Data#2
SFJohnson24 wants to merge 7 commits intomainfrom
rules

Conversation

@SFJohnson24
Copy link
Copy Markdown
Collaborator

@SFJohnson24 SFJohnson24 commented Mar 5, 2026

I left the audit file inside the repo for now--can remove but I want the rules with multiple test data sources to be resolved beforehand.

@SFJohnson24 SFJohnson24 self-assigned this Mar 5, 2026
@SFJohnson24 SFJohnson24 requested a review from gerrycampion March 5, 2026 20:59
@gerrycampion gerrycampion linked an issue Mar 6, 2026 that may be closed by this pull request
@RamilCDISC
Copy link
Copy Markdown

I am unable to submit review because of the size of the PR , the page becomes unresponsive. All looks good to me.

@gerrycampion
Copy link
Copy Markdown
Contributor

Due to the size, I will be writing review comments here instead of on the files

@gerrycampion
Copy link
Copy Markdown
Contributor

What is the purpose of the empty "engine" folder?

@gerrycampion
Copy link
Copy Markdown
Contributor

There is an issue with this header (3.0 | 3.1 | 3.1.1):

Rule ID,3.0,3.1,3.1.1,3.0 | 3.1 | 3.1.1,Status,CORE-ID

@SFJohnson24
Copy link
Copy Markdown
Collaborator Author

SFJohnson24 commented Apr 2, 2026

What is the purpose of the empty "engine" folder?

it is a github submodule of engine--verizian did the same thing and we will use it for the scripts/gitactions for authors. Not entirely sure why it is empty for you

@SFJohnson24
Copy link
Copy Markdown
Collaborator Author

SFJohnson24 commented Apr 2, 2026

There is an issue with this header (3.0 | 3.1 | 3.1.1):

this came from the FULL template rule, I deleted it and remade the mappings which resolved it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate rules from database to github

3 participants