Fix subdirectory listing under /dev mount point#37
Merged
JohnAmadis merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
read_driver_parent_directory() was generating paths without a leading
'/' (e.g. "dmgpio8/") while DMVFS passes paths with a leading '/'
(e.g. "/dmgpio8"). This caused all path comparisons in is_directory()
and related functions to fail, resulting in:
dmdevfs: [ERROR] Directory not found: /dmgpio8
dmdevfs: [ERROR] File not found: /dmgpio8
Fix:
- read_driver_parent_directory: add leading '/' to non-root parent
paths ("/%s%u/" and "/%sx/" instead of "%s%u/" and "%sx/")
- read_next_subdir_name: when listing from root '/', skip the leading
'/' now present in full_path before extracting the next component
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix directory listing issue for /dev folders
Fix subdirectory listing under /dev mount point
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ls /dev/dmgpio8failed with "Directory not found" becauseread_driver_parent_directory()built paths without a leading/(e.g."dmgpio8/") while DMVFS strips the mount prefix and passes paths with a leading/(e.g."/dmgpio8"), causing all comparisons inis_directory()to fail.Changes
read_driver_parent_directory— prepend/to non-root parent paths:read_next_subdir_name— when listing from root/, skip the leading/now present infull_pathbefore extracting the next component:Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.