feat: add SAN / ALIAS_DOMAIN support for dstack-ingress (CPL-139)#1
Closed
feat: add SAN / ALIAS_DOMAIN support for dstack-ingress (CPL-139)#1
Conversation
Refactor Route53DNSProvider methods to add support for weighted routing. Update methods to handle weighted routing parameters and adjust record ID parsing for weighted records.
Updated create_dns_record method to skip automatic weighting for TXT records and added comments for clarity.
…extensively and add double TXT support
…pport Remove Route53-specific weighted CNAME routing (ROUTE53_INITIAL_WEIGHT, set_weighted_cname, append_txt_record, set_alias_domain_cname) and the load-balanced docker-compose example. Retain ALIAS_DOMAIN as a pure SAN feature: - certbot issues SAN cert covering both DOMAIN and ALIAS_DOMAIN - nginx server_name includes ALIAS_DOMAIN - General Route53 provider support unchanged Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of Dstack-TEE/dstack-examples#83 by @wwwehr for evaluation and testing.
server_name, and appends the node'sAPP_ID:PORTto the alias domain's TXT recordALIAS_DOMAIN+ROUTE53_INITIAL_WEIGHTare set, creates a weight-0 weighted CNAME for the alias domain pointing to the node domain--cert-nameflagAcceptheaders for OCI/Docker manifest checksNew Environment Variables
ALIAS_DOMAINserver_name, appends alias TXT recordROUTE53_INITIAL_WEIGHTALIAS_DOMAIN, creates weight-0 alias CNAMEFiles Changed
scripts/dns_providers/route53.py— Weighted routing, append TXT, SAN supportscripts/dns_providers/base.py— Fallback implementations for new methodsscripts/dnsman.py— Newset_txt_appendandset_weighted_cnameactionsscripts/entrypoint.sh— ALIAS_DOMAIN handling in nginx and DNS setupscripts/certman.py— SAN cert expansion, certbot fixesdocker-compose.loadbalanced.yaml— Reference compose for multi-node setupDNS_PROVIDERS.md/README.md— DocumentationTest Plan
DOMAINandALIAS_DOMAINserver_nameincludes both domainsALIAS_DOMAINset — should behave identically to beforeTracks: CPL-139
🤖 Generated with Claude Code