Overhaul test suite: MCP tool-level integration tests#2
Merged
oleksandr-nc merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
- Add McpTestHelper that calls MCP tools by name through the full tool stack - All integration tests now exercise tools via MCP, not raw client calls - Add test_server.py: tool registration, descriptions, server configuration - Add test_permissions.py: READ/WRITE/DESTRUCTIVE enforcement end-to-end - Add test_errors.py: NextcloudError messages at client and MCP tool level - Split monolithic file lifecycle test into focused per-operation tests - Add per-test cleanup fixture to ensure test isolation - Add tests for edge cases: empty files, UTF-8, binary, large files, duplicates - 109 total tests (26 unit + 83 integration), all against real Nextcloud
Contributor
Author
|
Ready for review. Summary: Complete test suite overhaul — 109 tests (26 unit + 83 integration), all against real Nextcloud. Key changes:
CI green on NC 31 + NC 32. Tested locally on master + stable33 (twice each). |
oleksandr-nc
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpTestHelperfixture for easy tool invocation in teststest_server.py— tool registration, descriptions, server configurationtest_permissions.py— READ/WRITE/DESTRUCTIVE enforcement end-to-end against live Nextcloudtest_errors.py—NextcloudErrormessage quality at both client and MCP tool levelTest counts: 109 total (26 unit + 83 integration), all against real Nextcloud
Test plan
ruff check,ruff format --check,isort --check— cleanpyrightstrict — 0 errors