Add support for idempotency keys when creating tickets#808
Open
aleksei-averchenko-wise wants to merge 6 commits intocloudbees-oss:masterfrom
Open
Add support for idempotency keys when creating tickets#808aleksei-averchenko-wise wants to merge 6 commits intocloudbees-oss:masterfrom
aleksei-averchenko-wise wants to merge 6 commits intocloudbees-oss:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements support for Zendesk's idempotency key
feature when creating tickets. I happen to need to use this feature myself :)
What's Changed
Ticketobjects before creationIdempotency-Keyheader to the APITicket:getIdempotencyKey()/setIdempotencyKey(String)- the idempotency keygetIsIdempotencyHit()/setIsIdempotencyHit(Boolean)- whether this was a duplicate requestSee the usage example in the README.
Caveat
The current implementation doesn't properly update
idempotencyKeyandisIdempotencyHitwhen creating a ticket viaqueueCreateTicketAsync. I don't know what the best approach would be here, any comments are welcome.