Skip to content

fix: wire allow_any_source_repo into MCP argocd config tool#47

Open
saschabuehrle wants to merge 2 commits intocloudengine-labs:mainfrom
saschabuehrle:fix/issue-4
Open

fix: wire allow_any_source_repo into MCP argocd config tool#47
saschabuehrle wants to merge 2 commits intocloudengine-labs:mainfrom
saschabuehrle:fix/issue-4

Conversation

@saschabuehrle
Copy link

Bug

Fixes #4. The MCP generate_argocd_config tool did not expose allow_any_source_repo, even though the CLI and scaffold layer already support it.

Fix

  • Added allow_any_source_repo: bool = False to the MCP tool signature
  • Wired the value through to the scaffold namespace consumed by generate_argocd_appproject
  • Updated tool schemas (skills/openai_functions.json and skills/claude_tools.json) so API consumers can pass the option
  • Added a regression test in mcp_server/test_server.py to verify wildcard source repo output is available when enabled

Testing

  • uv run --with pytest --with mcp --with pyyaml pytest -q mcp_server/test_server.py -k "argocd"
  • python3 -m json.tool skills/openai_functions.json
  • python3 -m json.tool skills/claude_tools.json

Greetings, saschabuehrle

@chefgs
Copy link
Member

chefgs commented Mar 19, 2026

@saschabuehrle Thanks for picking up the issue #4

As mentioned in the Contribution guideline, we encourage contributors to add automated sanity tests to confirm the fix works. So it would be great, Could you please add tests for the changes you have made. Thanks in advance.

@saschabuehrle
Copy link
Author

Thanks for the note and the pointer to CONTRIBUTING.\n\nUnderstood � I should have confirmed assignment/coordination on #4 before opening the PR. If you prefer, I can close this PR and re-open work after issue assignment in the expected flow.\n\nGreetings, saschabuehrle

@chefgs
Copy link
Member

chefgs commented Mar 19, 2026

@saschabuehrle

Thank you for your understanding! I'll assign this PR on your name. Anyways this PR is already linked to the issue #4 since we mentioned it in the comments.

@saschabuehrle
Copy link
Author

Thanks for the review — I pushed an update that adds the missing test follow-through by removing the stale strict xfail now that is wired through MCP. This should clear the Sanity Tests failure (XPASS -> fail) and keep regression coverage in place.

@saschabuehrle
Copy link
Author

Update pushed: removed the stale strict xfail in TestMCPServerArgoCD for the allow_any_source_repo parameter now that the MCP tool supports it. This addresses the Sanity Tests XPASS failure and keeps the regression check active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG-3: MCP server generate_argocd_config missing allow_any_source_repo parameter

2 participants