fix: wire allow_any_source_repo into MCP argocd config tool#47
fix: wire allow_any_source_repo into MCP argocd config tool#47saschabuehrle wants to merge 2 commits intocloudengine-labs:mainfrom
Conversation
|
@saschabuehrle Thanks for picking up the issue #4 As mentioned in the Contribution guideline, we encourage contributors to add automated sanity tests to confirm the fix works. So it would be great, Could you please add tests for the changes you have made. Thanks in advance. |
|
Thanks for the note and the pointer to CONTRIBUTING.\n\nUnderstood � I should have confirmed assignment/coordination on #4 before opening the PR. If you prefer, I can close this PR and re-open work after issue assignment in the expected flow.\n\nGreetings, saschabuehrle |
|
Thank you for your understanding! I'll assign this PR on your name. Anyways this PR is already linked to the issue #4 since we mentioned it in the comments. |
|
Thanks for the review — I pushed an update that adds the missing test follow-through by removing the stale strict xfail now that is wired through MCP. This should clear the Sanity Tests failure (XPASS -> fail) and keep regression coverage in place. |
|
Update pushed: removed the stale strict xfail in TestMCPServerArgoCD for the allow_any_source_repo parameter now that the MCP tool supports it. This addresses the Sanity Tests XPASS failure and keeps the regression check active. |
Bug
Fixes #4. The MCP
generate_argocd_configtool did not exposeallow_any_source_repo, even though the CLI and scaffold layer already support it.Fix
allow_any_source_repo: bool = Falseto the MCP tool signaturegenerate_argocd_appprojectskills/openai_functions.jsonandskills/claude_tools.json) so API consumers can pass the optionmcp_server/test_server.pyto verify wildcard source repo output is available when enabledTesting
uv run --with pytest --with mcp --with pyyaml pytest -q mcp_server/test_server.py -k "argocd"python3 -m json.tool skills/openai_functions.jsonpython3 -m json.tool skills/claude_tools.jsonGreetings, saschabuehrle