Install buildpacks based on order on config#4981
Open
tomkennedy513 wants to merge 1 commit intocloudfoundry:mainfrom
Open
Install buildpacks based on order on config#4981tomkennedy513 wants to merge 1 commit intocloudfoundry:mainfrom
tomkennedy513 wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
- Account for existing system buildpacks by offsetting the install position - Skip index for buildpacks with explicit position in config resolves cloudfoundry#3798
tomkennedy513
force-pushed
the
deterministic-buildpack-install
branch
from
8b9f4ec to
b309377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
This change will install buildpacks in the same order as they are specified in the config without modifying the order of existing buildpacks. The buildpacks index in the config is passed to the install job that will shift the buildpack the final position.
An explanation of the use cases your change solves
This resolves Cloud Controller should install new buildpacks in a more deterministic order #3798
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests