Skip to content

CLOS-3833: Fix mysqlclient and cl-MySQL/MariaDB packages not upgrading when repos disabled#43

Merged
prilr merged 1 commit intocloudlinux:cloudlinuxfrom
prilr:CLOS-3833-fix-mysqlclient-upgrade
Apr 10, 2026
Merged

CLOS-3833: Fix mysqlclient and cl-MySQL/MariaDB packages not upgrading when repos disabled#43
prilr merged 1 commit intocloudlinux:cloudlinuxfrom
prilr:CLOS-3833-fix-mysqlclient-upgrade

Conversation

@prilr
Copy link
Copy Markdown
Collaborator

@prilr prilr commented Apr 9, 2026

When MySQL Governor manages the database, both repos in cl-mysql.repo (cl-mysql-meta and mysqclient) may be disabled. The clmysql_process() method would skip adding "cloudlinux" to mysql_types and skip producing CustomTargetRepositoryFile, causing finalize() to never produce the target repos. DNF then silently drops the upgrades for mysqlclient and cl-MariaDB/cl-MySQL packages because no target repo provides them.

After the change, the actor will now always register "cloudlinux" type and produce target repos when CL MySQL/MariaDB is detected, regardless of source repo enabled state.
The cl-mysql-meta target repo (in addition to mysqclient) is also force-enabled so cl-MariaDB-meta and module packages can be resolved.

…g when repos disabled

When MySQL Governor manages the database, both repos in cl-mysql.repo (cl-mysql-meta and mysqclient) may be disabled.
The clmysql_process() method would skip adding "cloudlinux" to mysql_types and skip producing CustomTargetRepositoryFile, causing finalize() to never produce the target repos.
DNF then silently drops the upgrades for mysqlclient and cl-MariaDB/cl-MySQL packages because no target repo provides them.

To fix it, always register "cloudlinux" type and produce target repos when CL MySQL/MariaDB is detected, regardless of source repo enabled state.
Also force-enable cl-mysql-meta target repo (in addition to mysqclient) so cl-MariaDB-meta and module packages can be resolved.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

Copy link
Copy Markdown
Collaborator

@azheregelya azheregelya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prilr prilr merged commit 2c9d0c9 into cloudlinux:cloudlinux Apr 10, 2026
1 check passed
@prilr prilr deleted the CLOS-3833-fix-mysqlclient-upgrade branch April 10, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants