Skip to content

feat(greenhouse): address UI feedback#1572

Open
taymoor89 wants to merge 6 commits intomainfrom
1508-address-ui-feedback
Open

feat(greenhouse): address UI feedback#1572
taymoor89 wants to merge 6 commits intomainfrom
1508-address-ui-feedback

Conversation

@taymoor89
Copy link
Copy Markdown
Contributor

@taymoor89 taymoor89 commented Mar 26, 2026

Summary

Addresses UI feedback for the Greenhouse admin panel.

Changes Made

  • Replace dedicated stats components with inline status bars (count + ready/not-ready) in PluginPresets and PluginPresetDetail
  • Add status bar and "View details" button to PluginInstances datagrid
  • Move Configuration to its own tab in PluginInstanceDetail, matching PluginPresetDetail structure
  • Rename BasicInformation to Details in PluginInstanceDetail and PluginPresetDetail

Related Issues

Testing Instructions

  1. pnpm i
  2. pnpm --filter greenhouse dev
  3. Navigate to PluginPresets, PluginPresetDetail, and PluginInstanceDetail pages and verify stats bars and tabs render correctly

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

@taymoor89 taymoor89 requested a review from a team as a code owner March 26, 2026 16:38
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: fe069f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taymoor89 taymoor89 self-assigned this Mar 26, 2026
@taymoor89 taymoor89 marked this pull request as draft March 26, 2026 16:39
@taymoor89 taymoor89 force-pushed the 1508-address-ui-feedback branch from e41edca to e95abb3 Compare March 26, 2026 16:39
@taymoor89 taymoor89 force-pushed the 1508-address-ui-feedback branch from e95abb3 to cd95a7b Compare March 30, 2026 08:58
@taymoor89 taymoor89 marked this pull request as ready for review March 30, 2026 10:08
@edda edda added the greenhouse-pr-preview Builds a PR preview for greenhouse shell app and plugins. label Mar 30, 2026
@edda
Copy link
Copy Markdown
Contributor

edda commented Mar 30, 2026

I like the status information in the status row. Takes up much less space than the previous cards 👍

Could you do one change please?

Don't use a primary button for the "View Details" in the list view. Instead make a hamburger/kebap context menu and add the "View Details" action in there. Like this:

context-menu-wireframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse-pr-preview Builds a PR preview for greenhouse shell app and plugins.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants