Add alerts for reconciliation and webhooks#671
Merged
PhilippMatthes merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughFive new Prometheus alerting rules were added to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@helm/bundles/cortex-nova/alerts/nova.alerts.yaml`:
- Around line 665-668: The alert CortexNovaWebhookErrorsHigh uses
controller_runtime_webhook_requests_total but divides error rates by only
code="200" (successes), producing errors/successes and possible divide-by-zero;
update the expr for CortexNovaWebhookErrorsHigh so the denominator uses the
total request rate (remove the code="200" label filter from the denominator)
i.e., use sum by (webhook) (rate(controller_runtime_webhook_requests_total[5m]))
as the denominator to compute errors/total correctly.
- Around line 630-632: The alert CortexNovaWorkqueueNotDrained incorrectly uses
rate() on the gauge workqueue_depth; change the expression to check the gauge
value directly by removing rate() and using sum by (name)
(workqueue_depth{service="cortex-nova-metrics"}) > 0 so the rule fires when
items are present in the queue (and keep the existing 15m for duration).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 36a6483b-a948-4e0f-8c65-1f665132cd68
📒 Files selected for processing (1)
helm/bundles/cortex-nova/alerts/nova.alerts.yaml
PhilippMatthes
force-pushed
the
add-controller-alerts
branch
from
e966ba4 to
3bebfbe
Compare
Contributor
Test Coverage ReportTest Coverage 📊: 68.4% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With controller-runtime's exporter, we're already exposing a rich set of metrics on which we can declare alerts. This change adds five alerts: one for reconciler errors, one for reconciler timeouts, one for the workqueue not being drained, one for the webhook latency, and one for the webhook error rate. These are basically the same as in greenhouse.