Skip to content

Remove duplicated from nova request #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umswmayj merged 3 commits into from
Mar 31, 2026
+426 −4
Merged

Remove duplicated from nova request #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b286f3
Remove duplicated nova servers
umswmayj Mar 31, 2026
dad1f81
Use ideomatic/safe way to check seen servers
PhilippMatthes Mar 31, 2026
800f9a6
Add it to other ep as well
umswmayj Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions internal/knowledge/datasources/plugins/openstack/nova/nova_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ func (api *novaAPI) GetAllServers(ctx context.Context) ([]Server, error) {
initialURL := api.sc.Endpoint + "servers/detail?all_tenants=true"
var nextURL = &initialURL
var allServers []Server
seen := make(map[string]struct{})

for nextURL != nil {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, *nextURL, http.NoBody)
Expand Down Expand Up @@ -122,7 +123,14 @@ func (api *novaAPI) GetAllServers(ctx context.Context) ([]Server, error) {
if err != nil {
return nil, err
}
allServers = append(allServers, list.Servers...)
for _, s := range list.Servers {
if _, ok := seen[s.ID]; ok {
slog.Warn("skipping duplicate server", "id", s.ID)
continue
}
seen[s.ID] = struct{}{}
allServers = append(allServers, s)
}
nextURL = nil
for _, link := range list.Links {
if link.Rel == "next" {
Expand Down Expand Up @@ -155,6 +163,7 @@ func (api *novaAPI) GetDeletedServers(ctx context.Context, since time.Time) ([]D
initialURL := api.sc.Endpoint + "servers/detail?status=DELETED&all_tenants=true&changes-since=" + url.QueryEscape(since.Format(time.RFC3339))
var nextURL = &initialURL
var deletedServers []DeletedServer
seen := make(map[string]struct{})

for nextURL != nil {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, *nextURL, http.NoBody)
Expand Down Expand Up @@ -182,7 +191,14 @@ func (api *novaAPI) GetDeletedServers(ctx context.Context, since time.Time) ([]D
if err != nil {
return nil, err
}
deletedServers = append(deletedServers, list.Servers...)
for _, s := range list.Servers {
if _, ok := seen[s.ID]; ok {
slog.Warn("skipping duplicate deleted server", "id", s.ID)
continue
}
seen[s.ID] = struct{}{}
deletedServers = append(deletedServers, s)
}
nextURL = nil
for _, link := range list.Links {
if link.Rel == "next" {
Expand Down Expand Up @@ -211,6 +227,7 @@ func (api *novaAPI) GetAllHypervisors(ctx context.Context) ([]Hypervisor, error)
initialURL := api.sc.Endpoint + "os-hypervisors/detail"
var nextURL = &initialURL
var hypervisors []Hypervisor
seen := make(map[string]struct{})
for nextURL != nil {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, *nextURL, http.NoBody)
if err != nil {
Expand All @@ -237,7 +254,14 @@ func (api *novaAPI) GetAllHypervisors(ctx context.Context) ([]Hypervisor, error)
if err != nil {
return nil, err
}
hypervisors = append(hypervisors, list.Hypervisors...)
for _, h := range list.Hypervisors {
if _, ok := seen[h.ID]; ok {
slog.Warn("skipping duplicate hypervisor", "id", h.ID)
continue
}
seen[h.ID] = struct{}{}
hypervisors = append(hypervisors, h)
}
nextURL = nil
for _, link := range list.Links {
if link.Rel == "next" {
Expand Down Expand Up @@ -301,6 +325,7 @@ func (api *novaAPI) GetAllMigrations(ctx context.Context) ([]Migration, error) {
initialURL := api.sc.Endpoint + "os-migrations"
var nextURL = &initialURL
var migrations []Migration
seen := make(map[string]struct{})
for nextURL != nil {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, *nextURL, http.NoBody)
if err != nil {
Expand Down Expand Up @@ -328,14 +353,21 @@ func (api *novaAPI) GetAllMigrations(ctx context.Context) ([]Migration, error) {
if err != nil {
return nil, err
}
for _, m := range list.Migrations {
if _, ok := seen[m.UUID]; ok {
slog.Warn("skipping duplicate migration", "uuid", m.UUID)
continue
}
seen[m.UUID] = struct{}{}
migrations = append(migrations, m)
}
nextURL = nil
for _, link := range list.Links {
if link.Rel == "next" {
nextURL = &link.Href
break
}
}
migrations = append(migrations, list.Migrations...)
}
slog.Info("fetched", "label", label, "count", len(migrations))
return migrations, nil
Expand Down
Loading
Loading