NodeController: Switch to IssuerReference

[fwiesel]

The ObjectReference has been deprecated, so go with the times.

Summary by CodeRabbit

• Refactor
  • Updated internal certificate issuer reference handling to use the appropriate data structure type.

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller	63.27% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_certificate_controller.go	81.63% (ø)	49	40	9

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd3e9b5f-c5b2-495b-a6d3-52481ce19510

📥 Commits

Reviewing files that changed from the base of the PR and between 80fff7f and df617c8.

📒 Files selected for processing (1)

• internal/controller/node_certificate_controller.go

---

📝 Walkthrough

Walkthrough

Updated the certificate.Spec.IssuerRef field assignment in the node certificate controller to use the correct cmmeta.IssuerReference type instead of cmmeta.ObjectReference. This is a single-line type correction with no impact on reconciliation logic or error handling.

Changes

Cohort / File(s)	Summary
Certificate Type Correction internal/controller/node_certificate_controller.go	Changed IssuerRef field assignment from generic ObjectReference to proper IssuerReference type in ensureCertificate method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A type was misplaced, oh what a sight,
From ObjectReference to Issuer's right,
One line corrected, the certificate gleams,
Now properly typed, fulfilling all schemes! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'NodeController: Switch to IssuerReference' directly and clearly summarizes the main change: updating NodeController to use IssuerReference instead of ObjectReference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issuer-reference

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}