HypervisorOffboarding: Decomission & Node are incorrect

[fwiesel]

The reconciler was already reconciling on a hypervisor custom-resource, so reflect that in the name.
"Decomission" is misspelled, so lets go with offboarding as it matches onboarding on the other side, and also we may offboard a hypervisor for various reasons, decommissioning being one of them.

Summary by CodeRabbit

• Refactor
  • Updated offboarding controller naming and terminology throughout the system. Status messages and condition reasons now consistently reference "offboarding" instead of "decommissioning" for improved clarity during hypervisor removal operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a589d447-28d1-4a0d-9ace-cc0fcf704a09

📥 Commits

Reviewing files that changed from the base of the PR and between e97eaa7 and 554d493.

📒 Files selected for processing (3)

• cmd/main.go
• internal/controller/offboarding_controller.go
• internal/controller/offboarding_controller_test.go

---

📝 Walkthrough

Walkthrough

This pull request renames the hypervisor controller from NodeDecommissionReconciler to HypervisorOffboardingReconciler and updates related constants, status messages, and condition reasons throughout the codebase from "decommissioning" to "offboarding" terminology.

Changes

Cohort / File(s)	Summary
Controller Implementation internal/controller/offboarding_controller.go	Renamed reconciler struct from NodeDecommissionReconciler to HypervisorOffboardingReconciler, updated controller constant DecommissionControllerName to OffboardingControllerName, renamed methods (setDecommissioningCondition → setOffboardingCondition), and updated all status messages and condition reasons from decommissioning to offboarding terminology.
Controller Wiring cmd/main.go	Updated controller registration from NodeDecommissionReconciler to HypervisorOffboardingReconciler and changed failure log message identifier accordingly.
Test Updates internal/controller/offboarding_controller_test.go	Renamed test suite and reconciler references from NodeDecommissionReconciler to HypervisorOffboardingReconciler, updated condition reason assertions from "Decommissioning" to "Offboarding", and adjusted test descriptions to match new terminology.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From decommissioning to offboarding we hop,
A rename so tidy, we'll never stop,
Controllers and reasons, all aligned now,
Hypervisors bid farewell with a bow! 🎩✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is partially related to the changeset. It mentions renaming from 'Decomission & Node' but doesn't clearly convey that the main change is renaming the controller to 'HypervisorOffboardingReconciler' and updating related terminology throughout the codebase.	Consider a clearer title like 'Rename NodeDecommissionReconciler to HypervisorOffboardingReconciler' or 'Update reconciler naming and fix decommissioning terminology' that better describes the primary refactoring.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch offboarding

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd	0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller	63.27% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd/main.go	0.00% (ø)	0	0	0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/offboarding_controller.go	71.88% (+71.88%)	64 (+64)	46 (+46)	18 (+18)	🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

• github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/offboarding_controller_test.go