chore(nix): add flake for developing and building lpm#69
chore(nix): add flake for developing and building lpm#69Silzinc wants to merge 13 commits intocodebycruz:masterfrom
Conversation
codebycruz
left a comment
There was a problem hiding this comment.
Assuming this pull request isn't a WIP anymore despite the name. In the future I'll probably mark these as draft to use GitHub's functionality which might be more clear.
Just some nitpicks pretty much, I think the flake can be simplified to be smaller but it is fine as is and I don't want to redo your gen-release script, although it would be nice to simplify that since this PR will take the repo to <99% Lua usage :(
| end | ||
|
|
||
| ---@return "musl" | "gnu" | nil | ||
| local function getPlatformLibc() |
There was a problem hiding this comment.
Can the changes in this file be undone now?
flake.nix
Outdated
| { self, nixpkgs, ... }: | ||
| let | ||
| platform_attrs = { | ||
| "aarch64-darwin" = { |
There was a problem hiding this comment.
Can probably hoist the v0.7.1 into a separate variable to deduplicate code and make it easier to update
flake.nix
Outdated
| with pkgs; | ||
| [ | ||
| luajit | ||
| stylua |
There was a problem hiding this comment.
At the moment stylua isn't necessary as LuaLS' formatter is being used. Additionally, luajit is not necessary unless you're using BOOTSTRAP=1 which is no longer used in the flake
|
It'll certainly be back above 99% soon enough :) |
…arate repo, pin last version in the devshell.
I managed to build lpm with this. Now, there are a few clear issues: