Stage

[ct-anjali-patel]

Commit Checklist

• Remove UNUSED comment code
• Remove any logging like console.log
• Remove all warnings and errors while build
• Check vulnerabilities
• Make sure build for production is working. Try running command for prod build in local.
• Fix prettier: npx prettier --write .
• Fix eslint: npx eslint src\ --fix command
• Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
• WCAG

General

• Follow import structure. module/third-party/files/component/style/types/asset
• Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
• Before adding custom style follow our pre-built components/elements

[phoenixcoded20]

{
"file": ".yarn/install-state.gz",
"approved": false,

"issues": [
{
"type": "best-practice",
"severity": "high",
"description": "The patch attempts to modify a binary file (.gz) which is not suitable for code reviews as it cannot be assessed for correctness or quality using standard tooling.",
"recommendedFix": "Avoid submitting binary file diffs for code review. Instead, only include text-based files.",
"codeFix": ""
}
]
}

[phoenixcoded20]

{
"file": "src/app/theme/layout/admin/admin.component.html",
"approved": false,

"issues": [
{
"type": "improvement",
"severity": "low",
"description": "The anchor tag lacks a 'rel' attribute when using target='_blank', which is a security risk. It is a best practice to use 'rel="noopener noreferrer"' to prevent potential security vulnerabilities.",
"recommendedFix": "Add 'rel="noopener noreferrer"' to the anchor tag for better security.",
"codeFix": "<a href="https://codedthemes.com/" target="_blank" rel="noopener noreferrer">CodedThemes"
}
]
}

[phoenixcoded20]

{
"file": "src/favicon.ico",
"approved": false,
"issues": [
{
"type": "bug",
"severity": "high",
"description": "The favicon.ico file is missing or corrupted, which can lead to the application not displaying a favicon properly in browsers.",
"recommendedFix": "Ensure that the favicon.ico file is present in the src directory and is a valid ICO file.",
"codeFix": "N/A (file issue, needs the correct favicon.ico file)"
}
]
}