Skip to content

⚡️ Speed up method Key.equals by 6% #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: fix/add-mockito-test-dependency
Choose a base branch
from
+23 −1
Open

⚡️ Speed up method Key.equals by 6% #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion client/src/com/aerospike/client/Key.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,31 @@ public boolean equals(Object obj) {

Key other = (Key) obj;

if (! Arrays.equals(digest, other.digest)) {
// Fast-path: same array reference -> compare namespace (same behavior as Arrays.equals + namespace.equals)
byte[] d1 = this.digest;
byte[] d2 = other.digest;

if (d1 == d2) {
return namespace.equals(other.namespace);
}

// If either is null (but not both), they are not equal.
if (d1 == null || d2 == null) {
return false;
}

// If lengths differ, not equal.
if (d1.length != d2.length) {
return false;
}

// Compare contents.
for (int i = 0, len = d1.length; i < len; i++) {
if (d1[i] != d2[i]) {
return false;
}
}

return namespace.equals(other.namespace);
}

Expand Down