Support $Dark UIID styles in dark mode with implicit inheritance by shai-almog · Pull Request #4648 · codenameone/CodenameOne

shai-almog · 2026-03-28T06:48:00Z

Motivation

Ensure when dark mode is enabled the UIManager prefers theme styles with a $Dark prefix for a UIID if they exist.
Make dark variants inherit from the original (non-dark) style by default so themes can override only the differences.
Allow explicit derive on $Dark styles to override the implicit inheritance behavior.

Description

Modified UIManager.createStyle(...) to check CN.isDarkMode() and resolve to a $Dark<UIID> variant when present via a new shouldUseDarkStyle(...) helper.
When a $Dark variant exists but does not define its own derive, the code now implicitly derives it from the original UIID using toDeriveStyleName(...), preserving existing explicit derive behavior.
Added helper hasStyleDefinition(...) to detect whether the dark variant is defined in themeProps.
Added unit tests maven/core-unittests/src/test/java/com/codename1/ui/plaf/UIManagerDarkModeStyleTest.java that cover: dark-style override + inherited base properties, selected-style dark variants (sel#), explicit dark derive overriding implicit inheritance, and fallback to the regular style when no $Dark variant exists; tests reset dark mode after each run.

Testing

Added and committed the code and test files, then attempted to run the new tests with:
- export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 && export PATH="$JAVA_HOME/bin:$PATH" && cd maven && mvn -pl core-unittests -am -DunitTests=true -Dmaven.javadoc.skip=true -Plocal-dev-javase -Dtest=UIManagerDarkModeStyleTest test which failed because the referenced Java 8 path is not available in this environment.
Re-ran with an available JDK but Maven could not complete due to external dependency resolution failures from Maven Central (HTTP 403), so the test suite could not be executed here.
The new tests are included in the PR and should pass in CI or a local environment configured per AGENTS.md (Java 8 JAVA_HOME + Maven access to central).

Codex Task

shai-almog · 2026-03-28T07:02:06Z

Compared 32 screenshots: 32 matched.

Native Android coverage

📊 Line coverage: 7.50% (3826/50985 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.91% (18948/320532), branch 2.79% (870/31131), complexity 3.51% (1046/29784), method 6.20% (861/13887), class 10.32% (190/1841)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.50% (3826/50985 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.91% (18948/320532), branch 2.79% (870/31131), complexity 3.51% (1046/29784), method 6.20% (861/13887), class 10.32% (190/1841)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

shai-almog · 2026-03-28T07:18:50Z

iOS screenshot updates

Compared 32 screenshots: 31 matched, 1 updated.

landscape — updated screenshot. Screenshot differs (2556x1179 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as landscape.png in workflow artifacts.

Benchmark Results

VM Translation Time: 0 seconds
Compilation Time: 149 seconds

Detailed Performance Metrics

Metric	Duration
Simulator Boot	1000 ms
Simulator Boot (Run)	2000 ms
App Install	6000 ms
App Launch	8000 ms
Test Execution	202000 ms

github-actions · 2026-03-28T09:03:20Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2340 total, 0 failed, 0 skipped
📊 Line coverage: 53.26% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 94 more
- ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 409 more
- ❌ codenameone-maven-plugin: 483 findings (High: 1, Normal: 314, Low: 168)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 480 more
- ❌ core-unittests: 1 findings (Normal: 1)
  - Top findings
    - Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

github-actions · 2026-03-28T09:38:44Z

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

AsciiDoc linter: 1 issue(s) flagged (1 errors) (exit code 1) (report)
Vale: 18574 alert(s) (2701 errors, 6342 warnings, 9531 suggestions) (exit code 1) (report)
Image references: 33 unused image(s) found (report)

Unused image preview:

img/uwp-app-manager-apps.png
img/uwp-certificate-generator.png
img/uwp-cn1settings-debug-desktop-selected.png
img/uwp-cn1settings-disk-icon.png
img/uwp-cn1settings-uwp.png
img/uwp-cn1settings-windows-settings-menu-item.png
img/uwp-dashboard-download-appxbundle.png
img/uwp-extract-zip-file.png
img/uwp-mobile-recently-added.png
img/uwp-mobile-settings-developer-mode.png
... and 23 more

Add dark-mode UIID style fallback with inheritance

89372ee

shai-almog added the codex label Mar 28, 2026 — with ChatGPT Codex Connector

Fix dark style inheritance recursion in UIManager

36bfc7a

Compile prefers-color-scheme dark CSS into UIIDs

e84651d

shai-almog merged commit 2f5dd00 into master Mar 28, 2026
17 checks passed

shai-almog mentioned this pull request Mar 28, 2026

Include proper darkmode support based in CSS #4639

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support $Dark UIID styles in dark mode with implicit inheritance#4648

Support $Dark UIID styles in dark mode with implicit inheritance#4648
shai-almog merged 3 commits intomasterfrom
codex/implement-dark-mode-style-inheritance

shai-almog commented Mar 28, 2026

Uh oh!

shai-almog commented Mar 28, 2026 •

edited

Loading

Uh oh!

shai-almog commented Mar 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented Mar 28, 2026

Motivation

Description

Testing

Uh oh!

shai-almog commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented Mar 28, 2026 •

edited

Loading

shai-almog commented Mar 28, 2026 •

edited

Loading

github-actions bot commented Mar 28, 2026 •

edited

Loading