Validate Javadoc snippets with timeout; simplify Playground bindings and add component resolution smoke test#4664
Closed
liannacasper wants to merge 2 commits intomasterfrom
Closed
Conversation
…-error-adcpww Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
Cloudflare Preview
|
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Display/UIManagerinstances andComponentfor scripts.Description
run_with_timeout()helper to.github/scripts/build_javadocs.shand invokevalidate-extracted-javadoc-snippets.shwith a 300-second timeout, printing a timeout message and exiting with the script status if validation fails.PlaygroundRunner.java, replaced fallback binding methods and now bindDisplaywithDisplay.getInstance()andUIManagerwithUIManager.getInstance(), removedresolveDisplayBinding()andresolveUiManagerBinding(), and addedComponentto the interpreter bindings and imported class.PlaygroundSmokeHarness.javato remove obsolete CSS-related smoke checks and addsmokeComponentTypeResolvesWithoutExplicitImport()which verifies thatComponent-typed code (e.g.Component c = new Label(...)) resolves without an explicit import.Testing
PlaygroundSmokeHarness(unit tests inscripts/cn1playground/common) and the newsmokeComponentTypeResolvesWithoutExplicitImport()test, and they passed.timeoututility is available.Codex Task