Validate javadoc snippets, simplify playground bindings, and allow local CN1 sources for registry generation#4665
Closed
liannacasper wants to merge 2 commits intomasterfrom
Closed
Conversation
…-error-76axjk Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
Cloudflare Preview
|
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DisplayandUIManagerto their instances and ensureComponentis available without explicit imports.generate-cn1-access-registry.shto use local Codename One sources for faster iteration and make the default behavior explicit in the tools README.Description
.github/scripts/build_javadocs.shto addrun_with_timeout, invokevalidate-extracted-javadoc-snippets.sh(with a 300s timeout) and propagate timeout/exit status with a clear message.PlaygroundRunner.javato setDisplayandUIManagertoDisplay.getInstance()andUIManager.getInstance()respectively, addComponentbinding and import, and removed the previous resolver helper methods.scripts/cn1playground/tools/generate-cn1-access-registry.shto supportCN1_ACCESS_USE_LOCAL_SOURCES=truefor scanning local source roots, keep the default of using release source jars, add robust download/extract error handling, and passCN1_SOURCE_ROOTSinto the registry generator when appropriate.scripts/cn1playground/tools/README.mdto document the default behavior and theCN1_ACCESS_USE_LOCAL_SOURCESoverride.PlaygroundSmokeHarness.javaby removing two CSS-related smoke checks and addingsmokeComponentTypeResolvesWithoutExplicitImportto validate implicitComponentresolution.Testing
PlaygroundSmokeHarness) and related unit tests; the modified smoke tests completed successfully.generate-cn1-access-registry.shlogic paths through code review and added runtime checks for missing local roots and download/extract failures (script exits on error as intended).Codex Task