Ensure Component is present in generated CN1 access registry, support local/release sources, and validate Javadoc snippets#4666
Closed
liannacasper wants to merge 2 commits intomasterfrom
Conversation
…-error-k8gcj2 Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
com.codename1.ui.Component(and other key UI types) to the BeanShell CN1 access registry so loose scripts can referenceComponentwithout explicit imports.Description
generate-cn1-access-registry.shto supportCN1_ACCESS_USE_LOCAL_SOURCES=trueto scan local repo sources, otherwise download and extract release source jars for the configuredcn1.version, with improved error handling and clearer logging.GenerateCN1AccessRegistry.java) to treat types missing from the runtime classpath as supported for registration so they can be emitted into the generated registry.run-playground-smoke-tests.shto always regenerate the registry from release sources before testing, verify the presence ofcom.codename1.ui.Componentand a set of key UI classes in the generatedGeneratedCN1Access.java, and run thePlaygroundSmokeHarnessvia Maven.PlaygroundRunnerto bindDisplayandUIManagerto their live instances and to exposeComponentto the interpreter namespace, removing the previous fallback resolver methods.smokeComponentTypeResolvesWithoutExplicitImport) that assertsComponentresolution without an explicit import in loose scripts, and simplified imports inPlaygroundSmokeHarness.run_with_timeouthelper and a pre-Javadoc validation step in.github/scripts/build_javadocs.shthat runsvalidate-extracted-javadoc-snippets.shwith a 300s timeout when present.scripts/cn1playground/tools/README.md) updated to explain the local vs release source behavior and the smoke-test verification steps.Testing
scripts/cn1playground/tools/run-playground-smoke-tests.sh, which regenerates the CN1 access registry, verifies requiredcom.codename1.ui.*entries (includingComponent), and then executescom.codenameone.playground.PlaygroundSmokeHarness; the smoke harness completed successfully.Codex Task