Validate Javadoc snippets; fix playground bindings; improve CN1 access registry generation and smoke-test verification#4667
Closed
liannacasper wants to merge 2 commits intomasterfrom
Conversation
…-error-5ek203 Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
Cloudflare Preview
|
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Componentusage) instead of using fragile resolver methods.Description
run_with_timeouthelper and pre-JavaDoc validation step that runsvalidate-extracted-javadoc-snippets.shwith a 300s timeout in.github/scripts/build_javadocs.sh.DisplayandUIManagerdirectly viaDisplay.getInstance()/UIManager.getInstance()and add an explicitComponentbinding and import inPlaygroundRunner.java, removing the prior resolver methods.smokeComponentTypeResolvesWithoutExplicitImport()test inPlaygroundSmokeHarnessthat verifies implicitComponentresolution works.scripts/cn1playground/tools/README.md, includingCN1_ACCESS_USE_LOCAL_SOURCESto control whether to scan local sources or release source jars.generate-cn1-access-registry.shto supportCN1_ACCESS_USE_LOCAL_SOURCES=true, robustly download/extract release source jars when used, and present clearer errors.run-playground-smoke-tests.shto usebash, regenerate the CN1 access registry from release sources before testing, and assert the generatedGeneratedCN1Access.javacontains expectedcom.codename1.ui.*classes (includingComponent) and omits internal sentinel classes before running the smoke harness.Testing
scripts/cn1playground/tools/run-playground-smoke-tests.sh, which regenerates the CN1 access registry and runs thePlaygroundSmokeHarnessvia Maven exec, and the smoke harness checks passed.GeneratedCN1Access.javasucceeded.Codex Task