Validate extracted Javadoc snippets during javadoc build; refresh GeneratedCN1Access (add java.time, remove impl entries)#4668
Merged
liannacasper merged 2 commits intomasterfrom Mar 30, 2026
Conversation
…-error-dffkjz Signed-off-by: liannacasper <67953602+liannacasper@users.noreply.github.com>
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
javadocand timeboxing validation.Description
run_with_timeout()helper and a pre-generation step in.github/scripts/build_javadocs.shthat runsvalidate-extracted-javadoc-snippets.sh(if executable) with a 300-second timeout and fails the script on timeout or non-zero exit.javadocinvocation and added explicit messaging on validation and timeout handling.scripts/cn1playground/common/src/main/java/bsh/cn1/GeneratedCN1Access.javato removecom.codename1.impl.*entries, addcom.codename1.ui.AbstractDialogand manyjava.time.*classes (including format/temporal types), and to expand/repartition the class/method/field index implementation (introduced additionalfill*Indexpartitions such as index 11) to accommodate the new entries.Testing
Codex Task