Fix cn1-playground reflection mapping generation with released source roots#4669
Closed
liannacasper wants to merge 1 commit intomasterfrom
Closed
Fix cn1-playground reflection mapping generation with released source roots#4669liannacasper wants to merge 1 commit intomasterfrom
liannacasper wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
com.codename1.*types by deletingisPublicRuntimeType/filterKnownTypesusage and the associated cache so discovery no longer depends onClass.forNamefor CN1 types.isDispatchClassandisSupportedTypelogic to keep package-level exclusions (e.g.com.codename1.impl) while avoiding runtime visibility checks that are invalid for the source-jar workflow.scripts/cn1playground/tools/src/main/java/com/codenameone/playground/tools/GenerateCN1AccessRegistry.javato restore correct reflection registry generation from source roots.Testing
javac -d /tmp/cn1tool scripts/cn1playground/tools/src/main/java/com/codenameone/playground/tools/GenerateCN1AccessRegistry.java, which succeeded../scripts/cn1playground/tools/generate-cn1-access-registry.shandCN1_VERSION=7.0.230 ./scripts/cn1playground/tools/generate-cn1-access-registry.sh, but both runs failed to download source jars due tocurl: (22) 403from the Maven endpoint in this environment, preventing a full end-to-end generation smoke test.Codex Task