initializr: default useLargerTextScaleBool to true in generated theme.css#4683
Merged
liannacasper merged 1 commit intomasterfrom Apr 1, 2026
Merged
Conversation
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
useLargerTextScaleBool: true;into barebones/Kotlintheme.csswhen generating a project by addingensureDefaultLargeTextScaleand invoking it beforebuildThemeCss()inGeneratorModel.useLargerTextScaleBooland leaves the CSS unchanged if present, otherwise it adds the constant inside an existing#Constantsblock or appends a new#Constantsblock.GeneratorModelMatrixTestto verify barebones and Kotlin templates producecommon/src/main/css/theme.csscontaininguseLargerTextScaleBool: true;.scripts/initializr/common/src/main/java/com/codename1/initializr/model/GeneratorModel.javaandscripts/initializr/common/src/test/java/com/codename1/initializr/model/GeneratorModelMatrixTest.java.Testing
cd scripts/initializr/common && mvn -Dtest=GeneratorModelMatrixTest testbut the environment failed to run Maven due to external resolution errors (Maven Central returned 403 for plugin resolution), so the test could not be executed here.JAVA_HOMEset also failed because the Java 8 path was not available in this environment, so no local test run succeeded.Codex Task