Add Swift/Kotlin native sample support, runtime validator, and iPhoneBuilder improvements#4684
Open
liannacasper wants to merge 7 commits intomasterfrom
Open
Add Swift/Kotlin native sample support, runtime validator, and iPhoneBuilder improvements#4684liannacasper wants to merge 7 commits intomasterfrom
liannacasper wants to merge 7 commits intomasterfrom
Conversation
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 33 screenshots: 33 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
package-info.javaandpackage.html) to mention Swift as a supported iOS native implementation language.IPhoneBuilderto use a newcn1_createNativeInterfacePeerhelper that looks up Objective-C/Swift classes by name and falls back to the app bundle-prefixed name, and changed native peer handling to use genericidvalues.SwiftKotlinNativeand platform implementations: a Kotlin implementationSwiftKotlinNativeImpl.ktfor Android and a Swift implementationcom_codenameone_examples_hellocodenameone_SwiftKotlinNativeImpl.swiftfor iOS.NativeInterfaceLanguageValidatorand wired it into the sample app (HelloCodenameOne.kt) to assert that Android useskotlinand iOS usesswiftimplementations at runtime.Testing
IPhoneBuilderand new sample source files; the build succeeded.Codex Task