Update Konflux refs and ubi digest manually (main branch)#3188
Open
simonbaird wants to merge 4 commits intoconforma:mainfrom
Open
Update Konflux refs and ubi digest manually (main branch)#3188simonbaird wants to merge 4 commits intoconforma:mainfrom
simonbaird wants to merge 4 commits intoconforma:mainfrom
Conversation
Motivated by an email talking about permission issues affecting the clair-scan and deprecated-image-check. Used this method: curl -sL https://github.com/simonbaird/konflux-pipeline-patcher/raw/main/pipeline-patcher | bash -s bump-task-refs
📝 WalkthroughWalkthroughUpdated Tekton task bundle digests in pipeline YAMLs, refreshed UBI9 runtime image digests in both Dockerfiles, and bumped OpenTelemetry and golang.org/x/sys indirect dependency versions in module files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
Contributor
Review Summary by QodoUpdate Konflux task refs and ubi-minimal base image digests
WalkthroughsDescription• Update Konflux task bundle references with latest SHA256 digests • Update ubi-minimal base image digest to latest version • Address permission issues affecting clair-scan and deprecated-image-check tasks Diagramflowchart LR
A["Tekton Pipeline Files"] -->|Update task bundle SHAs| B["14 Konflux tasks"]
C["Dockerfile Files"] -->|Update base image digest| D["ubi-minimal:latest"]
B --> E["Resolved permission issues"]
D --> E
File Changes1. .tekton/cli-main-pull-request.yaml
|
Contributor
Code Review by Qodo
1. Bundle bump script misses pipelines
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
acceptance/go.mod (1)
232-237: Consider aligning OTLP exporter modules with the OTel 1.42 core bump.Lines 232-237 move core OTel modules to
v1.42.0, whilego.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttpis stillv1.38.0(Line 233). Keeping the family aligned reduces version-skew maintenance risk.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@acceptance/go.mod` around lines 232 - 237, The OTLP HTTP exporter module version is out of sync: update the module go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from v1.38.0 to v1.42.0 so it matches the core OTel modules (e.g., go.opentelemetry.io/otel, go.opentelemetry.io/otel/metric, go.opentelemetry.io/otel/sdk, go.opentelemetry.io/otel/sdk/metric, go.opentelemetry.io/otel/trace) to avoid version skew.go.mod (1)
387-394: Please verify OpenTelemetry exporter/core version alignment.Core OTel modules were bumped to
v1.42.0, but exporter modules in this file remain atv1.38.0(Lines 388-390). If no compatibility constraint exists, aligning versions would reduce long-term dependency skew.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 387 - 394, The go.mod shows OpenTelemetry core modules at v1.42.0 while exporter modules otlptrace, otlptracegrpc, and otlptracehttp are pinned to v1.38.0; verify compatibility and either update those exporter lines (go.opentelemetry.io/otel/exporters/otlp/otlptrace, .../otlptracegrpc, .../otlptracehttp) to v1.42.0 to align versions or document/lock a specific reason for keeping them at v1.38.0 (e.g., add a comment or separate override) so dependency skew is intentional and tracked.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@acceptance/go.mod`:
- Around line 232-237: The OTLP HTTP exporter module version is out of sync:
update the module
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp from v1.38.0 to
v1.42.0 so it matches the core OTel modules (e.g., go.opentelemetry.io/otel,
go.opentelemetry.io/otel/metric, go.opentelemetry.io/otel/sdk,
go.opentelemetry.io/otel/sdk/metric, go.opentelemetry.io/otel/trace) to avoid
version skew.
In `@go.mod`:
- Around line 387-394: The go.mod shows OpenTelemetry core modules at v1.42.0
while exporter modules otlptrace, otlptracegrpc, and otlptracehttp are pinned to
v1.38.0; verify compatibility and either update those exporter lines
(go.opentelemetry.io/otel/exporters/otlp/otlptrace, .../otlptracegrpc,
.../otlptracehttp) to v1.42.0 to align versions or document/lock a specific
reason for keeping them at v1.38.0 (e.g., add a comment or separate override) so
dependency skew is intentional and tracked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0d01a6bf-d1b3-4fbf-bd52-6e700e2a8ee0
⛔ Files ignored due to path filters (3)
acceptance/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumtools/go.sumis excluded by!**/*.sum
📒 Files selected for processing (5)
.tekton/cli-main-pull-request.yaml.tekton/cli-main-push.yamlacceptance/go.modgo.modtools/go.mod
✅ Files skipped from review due to trivial changes (2)
- tools/go.mod
- .tekton/cli-main-push.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .tekton/cli-main-pull-request.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.