Draft
Conversation
Bisaloo
commented
Mar 26, 2026
Comment on lines
+29
to
+30
| gamma <- gamma - (gamma %*% xi %*% crossprod(xi, gamma)) / c(1 + crossprod(xi, gamma %*% xi)) | ||
| beta <- beta - gamma %*% xi %*% (crossprod(xi, beta) - yi) |
Author
There was a problem hiding this comment.
In this kind of cases, it may be smart to investigate how it's better to associate the operations because (AB)C might be more performant than A(BC).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to each commit, in order:
crossprod()/tcrossprod()r-lib/lintr#3035list2DF()base R function r-lib/lintr#2596Each one of these changes has a significant performance impact when the code pattern is benchmarked separately. I didn't measure the final impact of this on a typical use of lemur. A benchmark should be run, potentially with https://github.com/DavisVaughan/cross.
I think I didn't break anything but a review is needed. In all cases, I don't think this should be merged before the next Bioconductor release. I'm opening a draft PR now because I move on to other things and I forget.