docs: update list of unimplemented Docker features#4809
Open
IstvanCsVarga wants to merge 1 commit intocontainerd:mainfrom
Open
docs: update list of unimplemented Docker features#4809IstvanCsVarga wants to merge 1 commit intocontainerd:mainfrom
IstvanCsVarga wants to merge 1 commit intocontainerd:mainfrom
Conversation
- Mark --health-start-interval as unimplemented in command-reference.md, consistent with healthchecks.md which states it is not supported - Fix typo in compose push section: "docker-compose pull" -> "docker-compose push" - Expand unimplemented compose commands list with missing Docker Compose V2 subcommands: attach, ls, stats, wait, watch (events and scale were already listed) Partial fix for containerd#3867 Signed-off-by: Istvan Csaba Varga <istvan-csaba.varga@outlook.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took a pass at updating the unimplemented Docker features list in
docs/command-reference.md.Changes:
--health-start-intervalwas marked with 🐳 but the flag doesn't actually exist in the codebase.docs/healthchecks.mdalready says it's unsupported, so added an(unimplemented)note to match.nerdctl compose push— it saiddocker-compose pullinstead ofpush.events|scalebut nerdctl is also missingattach,ls,stats,wait, andwatch. Switched todocker compose(V2) syntax since V1 is EOL.Grepped through the source to double-check everything — all the "unimplemented" claims check out.
Partial fix for #3867