Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions implementations/node-sdk+web-sdk/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ const config = {
clientId: process.env.PUBLIC_NINETAILED_CLIENT_ID ?? '',
environment: process.env.PUBLIC_NINETAILED_ENVIRONMENT,
logLevel: 'debug',
analytics: { baseUrl: process.env.PUBLIC_INSIGHTS_API_BASE_URL },
personalization: { baseUrl: process.env.PUBLIC_EXPERIENCE_API_BASE_URL },
api: {
insightsBaseUrl: process.env.PUBLIC_INSIGHTS_API_BASE_URL,
experienceBaseUrl: process.env.PUBLIC_EXPERIENCE_API_BASE_URL,
},
},
} as const

Expand Down
6 changes: 4 additions & 2 deletions implementations/node-sdk/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ const optimizationConfig: OptimizationNodeConfig = {
clientId: process.env.PUBLIC_NINETAILED_CLIENT_ID ?? '',
environment: process.env.PUBLIC_NINETAILED_ENVIRONMENT ?? '',
logLevel: 'debug',
analytics: { baseUrl: process.env.PUBLIC_INSIGHTS_API_BASE_URL },
personalization: { baseUrl: process.env.PUBLIC_EXPERIENCE_API_BASE_URL },
api: {
insightsBaseUrl: process.env.PUBLIC_INSIGHTS_API_BASE_URL,
experienceBaseUrl: process.env.PUBLIC_EXPERIENCE_API_BASE_URL,
},
}

const sdk = new ContentfulOptimization(optimizationConfig)
Expand Down
8 changes: 1 addition & 7 deletions implementations/react-native-sdk/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,7 @@ function AppContent(): React.JSX.Element {

function App(): React.JSX.Element {
return (
<OptimizationProvider
clientId={ENV_CONFIG.optimization.clientId}
environment={ENV_CONFIG.optimization.environment}
personalization={{ baseUrl: ENV_CONFIG.api.experienceBaseUrl }}
analytics={{ baseUrl: ENV_CONFIG.api.insightsBaseUrl }}
logLevel="debug"
>
<OptimizationProvider {...ENV_CONFIG.optimization} logLevel="debug">
<AppContent />
</OptimizationProvider>
)
Expand Down
17 changes: 8 additions & 9 deletions implementations/react-native-sdk/env.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ interface EnvConfig {
optimization: {
clientId: string
environment: string
}
api: {
experienceBaseUrl: string
insightsBaseUrl: string
api: {
experienceBaseUrl: string
insightsBaseUrl: string
}
}
entries: {
personalized: string
Expand Down Expand Up @@ -56,11 +56,10 @@ export const ENV_CONFIG = {
optimization: {
clientId: PUBLIC_NINETAILED_CLIENT_ID,
environment: PUBLIC_NINETAILED_ENVIRONMENT,
},

api: {
experienceBaseUrl: getAndroidCompatibleUrl(PUBLIC_EXPERIENCE_API_BASE_URL),
insightsBaseUrl: getAndroidCompatibleUrl(PUBLIC_INSIGHTS_API_BASE_URL),
api: {
experienceBaseUrl: getAndroidCompatibleUrl(PUBLIC_EXPERIENCE_API_BASE_URL),
insightsBaseUrl: getAndroidCompatibleUrl(PUBLIC_INSIGHTS_API_BASE_URL),
},
},

entries: {
Expand Down
6 changes: 4 additions & 2 deletions implementations/web-sdk/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,10 @@ <h2>Event Stream</h2>
name: document.title,
version: '0.0.0',
},
analytics: { baseUrl: '<!--#echo var="NGINX_INSIGHTS_API_BASE_URL" -->' },
personalization: { baseUrl: '<!--#echo var="NGINX_EXPERIENCE_API_BASE_URL" -->' },
api: {
insightsBaseUrl: '<!--#echo var="NGINX_INSIGHTS_API_BASE_URL" -->',
experienceBaseUrl: '<!--#echo var="NGINX_EXPERIENCE_API_BASE_URL" -->',
},
})

attachOptimizationPreviewPanel({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ function createOptimizationConfig(): OptimizationConfig {
name: 'ContentfulOptimization SDK - React Web Reference',
version: '0.1.0',
},
analytics: {
baseUrl: INSIGHTS_API_BASE_URL,
},
personalization: {
baseUrl: EXPERIENCE_API_BASE_URL,
api: {
insightsBaseUrl: INSIGHTS_API_BASE_URL,
experienceBaseUrl: EXPERIENCE_API_BASE_URL,
},
}
}
Expand Down
6 changes: 4 additions & 2 deletions packages/node/node-sdk/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ const sdk = new ContentfulOptimization({
clientId: process.env.PUBLIC_NINETAILED_CLIENT_ID ?? '',
environment: process.env.PUBLIC_NINETAILED_ENVIRONMENT ?? '',
logLevel: 'debug',
analytics: { baseUrl: process.env.PUBLIC_INSIGHTS_API_BASE_URL },
personalization: { baseUrl: process.env.PUBLIC_EXPERIENCE_API_BASE_URL },
api: {
insightsBaseUrl: process.env.PUBLIC_INSIGHTS_API_BASE_URL,
experienceBaseUrl: process.env.PUBLIC_EXPERIENCE_API_BASE_URL,
},
})

const ctfl = contentful.createClient({
Expand Down
4 changes: 2 additions & 2 deletions packages/node/node-sdk/src/ContentfulOptimization.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ function mergeConfig(config: OptimizationNodeConfig): CoreStatelessConfig {
* @remarks
* This class adapts the stateless ContentfulOptimization Core for Node runtimes by
* applying environment-appropriate defaults (e.g., server channel, Node SDK
* library metadata). No analytics or personalization behavior is modified
* only configuration defaults differ.
* library metadata). No core runtime behavior is modified; only configuration
* defaults differ.
*
* @example
* ```ts
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native-sdk/dev/utils/sdkHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ export async function initializeSDK(
const sdkInstance = await ContentfulOptimization.create({
clientId,
environment,
personalization: { baseUrl: experienceBaseUrl },
analytics: { baseUrl: insightsBaseUrl },
api: {
experienceBaseUrl,
insightsBaseUrl,
},
logLevel: 'debug',
})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const loadNetInfoModule = async (): Promise<NetInfoModule> => {
* @example
* ```ts
* const cleanup = createOnlineChangeListener(async (isOnline) => {
* if (isOnline) await sdk.analytics.flush()
* if (isOnline) await sdk.flush()
* })
*
* // Later:
Expand Down
Loading
Loading