Skip to content

feat: Add ASTRO farmework preset option #110

Closed
Reetika-Chavan wants to merge 4 commits intodevelopmentfrom
CL-2514
Closed

feat: Add ASTRO farmework preset option #110
Reetika-Chavan wants to merge 4 commits intodevelopmentfrom
CL-2514

Conversation

@Reetika-Chavan
Copy link

feat: Add ASTRO farmework preset option

@Reetika-Chavan Reetika-Chavan requested review from a team as code owners March 12, 2026 12:24
@github-actions
Copy link

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 31 0 25 ❌ Failed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

❌ BUILD FAILED - Security checks failed

Please review and fix the security vulnerabilities before merging.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Astro framework preset to the CLI configuration and adjusts GitHub workflows related to SCA scanning and release automation.

Changes:

  • Add ASTRO to framework presets, output directory defaults, and server-command supported frameworks.
  • Update SCA scan workflow to continue on Snyk failure and add a follow-up contentstack/sca-policy step.
  • Change release workflow’s post-publish checkout ref from prod-qa-pipeline to main.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/config/index.ts Adds Astro preset to framework selection and default output directory mapping.
.github/workflows/sca-scan.yml Modifies SCA scan behavior (non-blocking Snyk step) and adds a policy enforcement step.
.github/workflows/release.yml Alters which ref is checked out before committing release metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

if: ${{ steps.release-plugin.conclusion == 'success' }}
with:
ref: 'prod-qa-pipeline'
ref: 'main'
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking out ref: 'main' here makes the later commit step depend on whatever main points to at execution time (it may advance after the workflow was triggered). To keep the release metadata commit consistent with the published version, consider checking out the triggering ref/SHA (e.g., ${{ github.sha }} / ${{ github.ref }}) unless you explicitly want to write to the latest main.

Suggested change
ref: 'main'
ref: ${{ github.sha }}

Copilot uses AI. Check for mistakes.
with:
args: --all-projects --fail-on=all
json: true
continue-on-error: true
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error: true makes the Snyk scan step non-blocking even though --fail-on=all is set. If the intent is to gate PRs via the subsequent contentstack/sca-policy step, ensure that action reliably fails the job on policy violations; otherwise vulnerabilities may slip through without failing the workflow.

Suggested change
continue-on-error: true
continue-on-error: false

Copilot uses AI. Check for mistakes.
args: --all-projects --fail-on=all
json: true
continue-on-error: true
- uses: contentstack/sca-policy@main
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow uses contentstack/sca-policy@main. For supply-chain security and reproducibility, pin this action to a tagged release or (preferably) a full commit SHA instead of a moving branch ref.

Suggested change
- uses: contentstack/sca-policy@main
- uses: contentstack/sca-policy@v1

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants