Align Executor concept and executor_ref with P4003#250
Align Executor concept and executor_ref with P4003#250mvandeberg wants to merge 1 commit intocppalliance:developfrom
Conversation
- Executor concept: pass continuation by reference in requires-expression to match stable-address semantics of all implementations - executor_ref constructor: constrain to Executor to reject non-conforming types at the call site instead of deferring to vtable instantiation - executor_ref::target(): add noexcept to both overloads (trivially non-throwing type-id comparison and static_cast)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR refines the Executor concept by requiring dispatch/post methods to accept a non-const lvalue reference for continuation parameters, and strengthens executor_ref's constructor constraint while adding noexcept qualifiers to target() methods. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
An automated preview of the documentation is available at https://250.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-04-01 22:51:51 UTC |
|
GCOVR code coverage report https://250.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-04-01 23:07:04 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #250 +/- ##
===========================================
- Coverage 92.50% 92.47% -0.03%
===========================================
Files 170 170
Lines 9348 9348
===========================================
- Hits 8647 8645 -2
- Misses 701 703 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary by CodeRabbit