TS-45056 Class hot reloading detected and coverage dump fixed #881
Merged
TS-45056 Class hot reloading detected and coverage dump fixed #881
Conversation
DreierF
requested changes
Apr 8, 2026
Contributor
DreierF
left a comment
DreierF
left a comment
There was a problem hiding this comment.
The approach looks good on the surface, but has some serious problems in some cases. I think we either need to more specifically detect the reload for individual jar files or at least ensure that if no duplicates is set, that the default warn does not crash the report generation, but just warn about the issue.
Contributor
Author
|
@DreierF Thanks for the review. I guess these are the pitfalls of Agentic Coding. Now a variant where primarily the duplication-detection is kept alive by sharing the visitor instance. |
DreierF
requested changes
Apr 9, 2026
stahlbauer
commented
Apr 10, 2026
stahlbauer
commented
Apr 10, 2026
stahlbauer
commented
Apr 10, 2026
stahlbauer
commented
Apr 10, 2026
DreierF
requested changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue TS-45056
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.