TS-46135: Fix coverage aggregation skipped when tests fail#885
Open
TS-46135: Fix coverage aggregation skipped when tests fail#885
Conversation
…tinue Remove explicit dependsOn(buildDependencies) calls from CompactCoverageAggregationPlugin. The implicit dependency through @InputFiles on executionData/classDirectories is sufficient for task ordering and, unlike explicit dependsOn, does not block the aggregation task when a test task fails with --continue. This matches the pattern used by Gradle's official jacoco-report-aggregation plugin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
DreierF
force-pushed
the
ts/46135_coverage_aggregation_test_fail
branch
from
ec349b1 to
9022074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove explicit dependsOn(buildDependencies) calls from CompactCoverageAggregationPlugin. The implicit dependency through @InputFiles on executionData/classDirectories is sufficient for task ordering and, unlike explicit dependsOn, does not block the aggregation task when a test task fails with --continue.
This matches the pattern used by Gradle's official jacoco-report-aggregation plugin.
Addresses issue TS-46135
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.