fix: fix '(' mapping and add more key mappings#45
Open
Romulad wants to merge 2 commits intocrutchcorn:mainfrom
Open
fix: fix '(' mapping and add more key mappings#45Romulad wants to merge 2 commits intocrutchcorn:mainfrom
Romulad wants to merge 2 commits intocrutchcorn:mainfrom
Conversation
Owner
|
Whoops! I marked this as a "ready for review" PR despite you making it a draft. This LGTM - is it ready to go from your perspective? |
commit: |
Contributor
Author
|
Yes, it’s ready from my perspective. I’m also thinking about a potential improvement to make the key mapping more scalable. I’ll open an issue about that. |
Owner
|
Love it! Look forward to seeing it :) |
Contributor
Author
|
Great! |
Contributor
Author
|
Here my suggestion: #46 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Extend the default key map to support additional characters such as
/and:.Why:
Currently, some common characters are not handled correctly by the default key map.
For example:
Produces:
This happens because characters like
/and:are not mapped, leading to Unknown outputs.How:
Checklist: