Skip to content

Fix NoneType crash in test_gapfill_database when media is None #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jplfaria wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NoneType crash in test_gapfill_database when media is None #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions modelseedpy/core/msgapfill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,19 +132,20 @@ def test_gapfill_database(self, media, target=None, before_filtering=True,active
return True
if self.gfpkgmgr.getpkg("GapfillingPkg").test_solution.status == 'infeasible':
return False
media_id = media.id if media else "Complete"
gf_sensitivity = {}
if target != "rxn00062_c0":
gf_sensitivity = self.mdlutl.get_attributes("gf_sensitivity", {})
if media.id not in gf_sensitivity:
gf_sensitivity[media.id] = {}
if target not in gf_sensitivity[media.id]:
gf_sensitivity[media.id][target] = {}
if media_id not in gf_sensitivity:
gf_sensitivity[media_id] = {}
if target not in gf_sensitivity[media_id]:
gf_sensitivity[media_id][target] = {}
filter_msg = " "
note = "FAF"
if before_filtering:
filter_msg = " before filtering "
note = "FBF"
gf_sensitivity[media.id][target][
gf_sensitivity[media_id][target][
note
] = self.mdlutl.find_unproducible_biomass_compounds(target)
if target != "rxn00062_c0":
Expand All @@ -153,7 +154,7 @@ def test_gapfill_database(self, media, target=None, before_filtering=True,active
"No gapfilling solution found"
+ filter_msg
+ "for "
+ media.id
+ media_id
+ " activating "
+ target
)
Expand Down