DAOS-18520 test: test_aggregation_throttling - AssertionError: False is not true#17748
Open
DAOS-18520 test: test_aggregation_throttling - AssertionError: False is not true#17748
Conversation
Test-tag: test_snapshot_aggregation Skip-unit-tests: true Test-repeat: 10 Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
…is not true Description: Update expected_perf_diff from 30 to 35 Skip-unit-tests: true Skip-fault-injection-test: true Required-githooks: true Signed-off-by: Ding-Hwa Ho <ding-hwa.ho@hpe.com>
|
Ticket title is 'aggregation/throttling.py:DaosAggregationThrottling.test_aggregation_throttling - AssertionError: False is not true' |
Comment on lines
75
to
+76
| # keep it at 30 % | ||
| expected_perf_diff = 30.0 | ||
| expected_perf_diff = 35.0 |
Contributor
There was a problem hiding this comment.
The comment does not align with the number now. I would suggest just removing the comment since it is no longer relevant anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: