common: fix "The pool was not closed" message (no ADR failure)#36
common: fix "The pool was not closed" message (no ADR failure)#36janekmi merged 4 commits intostable-2.1from
Conversation
janekmi
force-pushed
the
janekmi/DAOS-18692-no-ADR-message-fix
branch
from
ca9ec4b to
16ce8ec
Compare
janekmi
force-pushed
the
janekmi/DAOS-18692-no-ADR-message-fix
branch
from
16ce8ec to
3c78745
Compare
Ref: DAOS-18692 Ref: #1 Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
force-pushed
the
janekmi/DAOS-18692-no-ADR-message-fix
branch
from
3c78745 to
4406089
Compare
grom72
left a comment
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 file and made 1 comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on janekmi and osalyk).
src/common/shutdown_state.c line 211 at r1 (raw file):
*/ CORE_LOG_WARNING( "The pool was not closed - reinitializing ADR failure detection.");
Suggestion:
The pool was not closed - reinitializing the ADR failure detection state.
osalyk
left a comment
osalyk
left a comment
There was a problem hiding this comment.
@osalyk reviewed 4 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on janekmi).
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
left a comment
janekmi
left a comment
There was a problem hiding this comment.
@janekmi made 1 comment.
Reviewable status: 1 of 9 files reviewed, 1 unresolved discussion (waiting on grom72 and osalyk).
src/common/shutdown_state.c line 211 at r1 (raw file):
*/ CORE_LOG_WARNING( "The pool was not closed - reinitializing ADR failure detection.");
Done.
Update *call_all*. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
left a comment
janekmi
left a comment
There was a problem hiding this comment.
@janekmi made 1 comment.
Reviewable status: 1 of 10 files reviewed, 2 unresolved discussions (waiting on grom72 and osalyk).
src/common/shutdown_state.c line 211 at r1 (raw file):
*/ CORE_LOG_WARNING( "The pool was not closed - reinitializing ADR failure detection.");
Refined message. @grom72 please me let know what do you think.
Suggestion:
The pool was not closed, leaving it vulnerable to ADR failures. Luckily, no ADR failure occurred this time
grom72
left a comment
grom72
left a comment
There was a problem hiding this comment.
@grom72 made 1 comment.
Reviewable status: 1 of 10 files reviewed, 2 unresolved discussions (waiting on janekmi and osalyk).
src/common/shutdown_state.c line 211 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Refined message. @grom72 please me let know what do you think.
The pool was not fully closed last time, ....
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
left a comment
janekmi
left a comment
There was a problem hiding this comment.
@janekmi made 1 comment and resolved 1 discussion.
Reviewable status: 1 of 10 files reviewed, 1 unresolved discussion (waiting on grom72 and osalyk).
src/common/shutdown_state.c line 211 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
The pool was not fully closed last time, ....
Done.
osalyk
left a comment
osalyk
left a comment
There was a problem hiding this comment.
@osalyk reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on grom72).
grom72
left a comment
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 10 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on janekmi).
grom72
left a comment
grom72
left a comment
There was a problem hiding this comment.
@grom72 made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on janekmi).
3 participants
Ref: DAOS-18692
Ref: #1
This change is