fix(vuetify): separate composable auto-imports from component resolution#29
Open
fix(vuetify): separate composable auto-imports from component resolution#29
Conversation
Previously, autoImports in lib-vuetify mixed composables (from lib-vue) with .vue component default exports. This was incorrect: unplugin-auto-import handles script-level imports only, not template component resolution. The .vue entries had no effect and caused "Cannot optimize dependency" warnings from Vite since esbuild cannot pre-bundle .vue files. autoImports now re-exports lib-vue composables only (backwards-compatible, existing consumers using autoImports keep working unchanged). A new componentsResolver is added for unplugin-vue-components, which properly resolves Df-prefixed components (e.g. <DfPersonalMenu> or <df-personal-menu>) to their @data-fair/lib-vuetify/*.vue modules. Also adds TSDoc to autoImports, componentsResolver, and settingsPath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoImportsinlib-vuetify/vite.tspreviously mixed composables (fromlib-vue) with.vuecomponent default exports. This was a bug:unplugin-auto-importonly handles<script>-level imports, not template component resolution. The.vueentries had no effect and caused Vite "Cannot optimize dependency" warnings since esbuild cannot pre-bundle.vuefiles.autoImportsnow re-exportslib-vuecomposables only. Backwards-compatible: existing consumers importingautoImportsfromlib-vuetifykeep working unchanged — they get the same composables as before, without the broken.vueentries.componentsResolverforunplugin-vue-components: properly resolvesDf-prefixed components (e.g.<DfPersonalMenu>or<df-personal-menu>) to their@data-fair/lib-vuetify/*.vuemodules.autoImports(in bothlib-vueandlib-vuetify) andcomponentsResolver.Migration
To enable component auto-resolution, add the resolver:
Test plan
<df-personal-menu>without manual import — component resolves correctly.vuefiles are gone