FIX: Propagate record conversion errors as PyErr in DBNDecoder#124
Open
wtn wants to merge 1 commit intodatabento:devfrom
Open
FIX: Propagate record conversion errors as PyErr in DBNDecoder#124wtn wants to merge 1 commit intodatabento:devfrom
wtn wants to merge 1 commit intodatabento:devfrom
Conversation
edc940b to
0b7b35e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBNDecoder.decode()panicked on record conversion failure because the innerpush_reccalled.unwrap()oninto_py_any(py).This change extracts
push_recto module scope with return typePyResult<()>so errors propagate to the Python caller instead.Motivation: The existing code was not breaking, but had a comment referencing a clippy bug. I found that the clippy behavior is OK, so I fixed up the code here.
Type of change
How has this change been tested?
I ran tests locally and with a regression test (not necessary to keep permanently).
Checklist
scripts/build.sh)scripts/lint.shandscripts/format.sh)scripts/test.sh)Declaration
I confirm this contribution is made under an Apache 2.0 license and that I have the authority
necessary to make this contribution on behalf of its copyright owner.