FIX: Remove tracemalloc.stop() from memory leak tests#125
Open
wtn wants to merge 1 commit intodatabento:devfrom
Open
FIX: Remove tracemalloc.stop() from memory leak tests#125wtn wants to merge 1 commit intodatabento:devfrom
wtn wants to merge 1 commit intodatabento:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI fails intermittently on memory leak tests, such as here.
The failing memory leak tests called
tracemalloc.stop()insidePython::attach. Under concurrent test execution this races withtracemalloc_raw_allocin other threads, causing a SIGSEGV. Removing the calls fixes the crash without affecting the measurements.Replication details
The faulting thread was
case_1_csv_mbo. Its stack was:The CSV encoder's
Droptriggered aPython::attach, which calledPyGILState_Ensure→new_threadstate→tracemalloc_raw_alloc. That allocator hook tried to calltraceback_new, which dereferenced a pointer at offset 8 from null, becausetracemalloc.stop()in the memory leak test had already freed the internal traceback table.I've replicated locally on macOS with the following looped command:
Note: It triggers readily on older slow systems but is harder to trigger on newer fast systems. When I did trigger it on a current device, it was while running multiple instances simultaneously.
Type of change
Checklist
scripts/build.sh)scripts/lint.shandscripts/format.sh)scripts/test.sh)Declaration
I confirm this contribution is made under an Apache 2.0 license and that I have the authority
necessary to make this contribution on behalf of its copyright owner.