Skip to content

WHO_TuberculosisBacteriologicallyConfirmedPercentage#1939

Open
shvngisingh wants to merge 11 commits intodatacommonsorg:masterfrom
shvngisingh:tuberculosis_percentage
Open

WHO_TuberculosisBacteriologicallyConfirmedPercentage#1939
shvngisingh wants to merge 11 commits intodatacommonsorg:masterfrom
shvngisingh:tuberculosis_percentage

Conversation

@shvngisingh
Copy link
Copy Markdown

@shvngisingh shvngisingh commented Mar 30, 2026

Tuberculosis: Percentage of people diagnosed with a new episode of pulmonary TB whose disease was bacteriologically confirmed
data source: https://data.who.int/indicators/i/1891124/449F55C

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 30, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new data import for the WHO Tuberculosis Percentage dataset, including the necessary download script, configuration files, and test data. The review identified several issues regarding file path conventions, incorrect script references in the documentation, and a need for more robust error handling in the download script. These changes are necessary to ensure the import automation functions correctly.

Comment thread statvar_imports/tuberculosis_percentage/download_who_tuberculosis.py Outdated
Comment thread statvar_imports/tuberculosis_percentage/README.md Outdated
Comment thread statvar_imports/tuberculosis_percentage/README.md Outdated
@shvngisingh shvngisingh force-pushed the tuberculosis_percentage branch from 345605a to 46594cf Compare March 31, 2026 07:01
Comment thread statvar_imports/tuberculosis_percentage/manifest.json Outdated
Copy link
Copy Markdown
Contributor

@saanikaaa saanikaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls address Gemini review comments also add PR checklist in description

@saanikaaa
Copy link
Copy Markdown
Contributor

Add PR checklist

@saanikaaa
Copy link
Copy Markdown
Contributor

Lets rectify the PR name to "WHO_TuberculosisBacteriologicallyConfirmedPercentage Import configs"

@shvngisingh shvngisingh changed the title tuberculosis_percentage WHO_TuberculosisBacteriologicallyConfirmedPercentage Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants