Skip to content

adding geocordinates#1974

Merged
balit-raibot merged 5 commits intodatacommonsorg:masterfrom
balit-raibot:schema_changes_noaa_bq
Apr 22, 2026
Merged

adding geocordinates#1974
balit-raibot merged 5 commits intodatacommonsorg:masterfrom
balit-raibot:schema_changes_noaa_bq

Conversation

@balit-raibot
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery dataset IDs and introduces a separate staging dataset for NOAA GFS data ingestion. It also adds a geo_coordinates column to the final table, populated via a spatial point function. Feedback suggests using the existing longitude and latitude columns from the staging table directly instead of parsing them from the placeName string using regular expressions, which is more efficient and robust.

Comment thread scripts/noaa_gfs/dc_bq_ingest.py Outdated
@balit-raibot balit-raibot enabled auto-merge (squash) April 22, 2026 12:51
@balit-raibot balit-raibot merged commit e2d15b9 into datacommonsorg:master Apr 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants