Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes redundant logging in the file uploader, updates workflow IDs in logs, and modifies the import helper to use a more specific file pattern for graph paths. Additionally, the manifest configuration was updated to include graph_data_path and remove cron schedules and resource limits. Review feedback highlighted a naming inconsistency between the code and the manifest for the graph data path attribute, as well as a concern regarding the redirection of command output to a log file in the download script, which could hinder debugging.
| Returns: | ||
| A ValidationResult object. | ||
| """ | ||
| if summary is None: |
There was a problem hiding this comment.
Wouldn't summary be None for an import that has never been run (or run successfully) where there is no previous successful run to diff against?
| 'EMPTY_IMPORT_CHECK', | ||
| message="Differ summary is missing.") | ||
|
|
||
| if 'current_obs_size' not in summary or 'current_schema_size' not in summary: |
There was a problem hiding this comment.
Can we use the validation report.json instead of differ for checking empty import output or even just check the import output files rows for imports that may have disabled differ and validations?
2 participants
No description provided.