Skip to content

Populate name fields in nodes#499

Open
vish-cs wants to merge 1 commit intodatacommonsorg:masterfrom
vish-cs:node
Open

Populate name fields in nodes#499
vish-cs wants to merge 1 commit intodatacommonsorg:masterfrom
vish-cs:node

Conversation

@vish-cs
Copy link
Copy Markdown
Contributor

@vish-cs vish-cs commented Apr 20, 2026

Population name column in spanner Node table during ingestion. This is done by by updating the name field during Node creation when the source MCF may not have name property added.
Minor clean up.

@vish-cs vish-cs requested a review from n-h-diaz April 20, 2026 07:25
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies GraphReader to ensure that nodes are assigned a name, defaulting to the subjectId if the name property is empty. A review comment suggests using GraphUtils.getPropVal instead of getPropertyValue to prevent potential IndexOutOfBoundsException errors and avoid incorrect double-quoting of values containing commas.

Comment thread pipeline/util/src/main/java/org/datacommons/ingestion/util/GraphReader.java Outdated
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 20, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants