Skip to content

rough implementation of a capture filter#45

Open
imskyyc wants to merge 7 commits intodevSparkle:mainfrom
imskyyc:main
Open

rough implementation of a capture filter#45
imskyyc wants to merge 7 commits intodevSparkle:mainfrom
imskyyc:main

Conversation

@imskyyc
Copy link
Copy Markdown

@imskyyc imskyyc commented Mar 25, 2026

fix typechecking issues (in possibly the worst way i could think of)

this is untested! i'm still working on this :)

@imskyyc imskyyc marked this pull request as ready for review March 26, 2026 22:16
@imskyyc
Copy link
Copy Markdown
Author

imskyyc commented Mar 26, 2026

opening this up because it is working now!

@devSparkle devSparkle self-assigned this Apr 4, 2026
@devSparkle
Copy link
Copy Markdown
Owner

Hi!

Thank you for this awsome contribution! I'm still reviewing, I'd just like to leave a few notes.

  1. I've gone ahead and reverted style changes — it was making it difficult to distinguish between styling and code changes, which was hampering review. If you'd like to propose style changes, I'm more than happy to consider them in a seperate commit.
  2. Thanks for the added support of the SDK as a Git Submodule! I'll be testing this seperately, and if it checks out cherry-picking the commit onto main.

@imskyyc
Copy link
Copy Markdown
Author

imskyyc commented Apr 4, 2026

Hi!

Thank you for this awsome contribution! I'm still reviewing, I'd just like to leave a few notes.

  1. I've gone ahead and reverted style changes — it was making it difficult to distinguish between styling and code changes, which was hampering review. If you'd like to propose style changes, I'm more than happy to consider them in a seperate commit.
  2. Thanks for the added support of the SDK as a Git Submodule! I'll be testing this seperately, and if it checks out cherry-picking the commit onto main.

Apologies for the styling changes, my IDE applied them automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants