docker(install): retry macOS archive installs on transient apt mirror failures#1090
Merged
crazy-max merged 1 commit intodocker:mainfrom Apr 17, 2026
Merged
Conversation
tcely
reviewed
Apr 16, 2026
| max_attempts=3 | ||
| until [ "$attempt" -gt "$max_attempts" ]; do | ||
| echo "Docker install attempt $attempt/$max_attempts" | ||
| if curl -fsSL https://get.docker.com | sh -s -- --channel {{srcArchiveChannel}} --version {{srcArchiveVersion}}; then |
There was a problem hiding this comment.
Doesn't it make sense to store the curl output and possibly use the --retry 5 option before the loop?
Member
Author
There was a problem hiding this comment.
Sounds good to have curl --retry as an extra guard, but the failure here was inside get.docker.com during apt-get update, after curl had already succeeded.
8039559 to
b54f595
Compare
tcely
suggested changes
Apr 16, 2026
tcely
left a comment
There was a problem hiding this comment.
Rather than a hard-coded file in /tmp using mktemp is safer.
The execute permission is unnecessary because we are invoking sh not the script file.
Member
Author
|
Good catch makes sense thx |
b54f595 to
a277844
Compare
tcely
approved these changes
Apr 16, 2026
a277844 to
7f1a6e0
Compare
… failures Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
7f1a6e0 to
c3d1cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/docker/actions-toolkit/actions/runs/24534040516/job/71724508344#step:10:1656